Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings from GHC 8.4.4 #149

Closed
jiegillet opened this issue Nov 15, 2018 · 0 comments
Closed

Warnings from GHC 8.4.4 #149

jiegillet opened this issue Nov 15, 2018 · 0 comments
Assignees
@jiegillet
Labels
bug Something isn't working
Milestone
v1.0.0: Public re...

Comments

@jiegillet
Copy link
Collaborator

jiegillet commented Nov 15, 2018 •
edited
Loading

Since switching to GHC 8.4.4, there's been a bunch of new warnings, especially warning: [-Wpartial-fields] Use of partial record field selector because of data structures like

data KeysDiff
    = Equal
    | FstIsPref { diff :: !Key}

since you can apply diff to FstIsPref but not Equal.

According to the organization style guide: "Records for data types with multiple constructors are forbidden.", so we should remove the record syntax.

Also a warning about module warning [-Wmissing-export-lists] The export item ‘module Main’ is missing an export list in Playground.hs
@jiegillet jiegillet added the bug Something isn't working label Nov 15, 2018
@jiegillet jiegillet self-assigned this Nov 15, 2018
jiegillet added a commit to jiegillet/tomland that referenced this issue Nov 15, 2018
@jiegillet
[kowainik#149] Warnings from GHC 8.4.4
c7bf5e3
@jiegillet jiegillet mentioned this issue Nov 15, 2018
Merged
jiegillet added a commit to jiegillet/tomland that referenced this issue Nov 18, 2018
@jiegillet
[kowainik#149] Warnings from GHC 8.4.4
a61d135
chshersh pushed a commit that referenced this issue Nov 20, 2018
@jiegillet @chshersh
[#149] Removing record syntax from PrefixTree (#150)
4a47b14 
* [#149] Warnings from GHC 8.4.4

* CHANGELOG

* Added documentation

* Added doc for constructors
@chshersh chshersh added this to the v1.0.0: Public release milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiegillet jiegillet

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.0: Public release
Development

No branches or pull requests
2 participants
@chshersh @jiegillet