Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'ByteString' newtypes for Generic coding #251

Closed
4 tasks
chshersh opened this issue Mar 12, 2020 · 0 comments · Fixed by #306
Closed
4 tasks

Add 'ByteString' newtypes for Generic coding #251

chshersh opened this issue Mar 12, 2020 · 0 comments · Fixed by #306
Assignees
@vrom911
Labels
codec Conversion between TOML and custom user data types generics Generic bidirectional codecs good first issue Good for newcomers
Milestone
v1.3.0.0: Big update

Comments

@chshersh
Copy link
Contributor

There are two ways to encode ByteString in TOML:

  1. Via text.
  2. Via array of integers (aka array of bytes).

To handle these cases, it's better to provide newtypes, specifically:

  • ByteStringAsText
  • ByteStringAsBytes
  • LByteStringAsText
  • LByteStringAsBytes
@chshersh chshersh added good first issue Good for newcomers codec Conversion between TOML and custom user data types generics Generic bidirectional codecs labels Mar 12, 2020
@chshersh chshersh mentioned this issue Mar 12, 2020
Merged
@chshersh chshersh added this to the v1.3.0.0: Big update milestone May 6, 2020
@vrom911 vrom911 self-assigned this May 18, 2020
vrom911 added a commit that referenced this issue May 18, 2020
@vrom911
[#251] Add 'ByteString' newtypes for Generic coding
cd87ea1 
Resolves #251
@vrom911 vrom911 mentioned this issue May 18, 2020
Merged
chshersh pushed a commit that referenced this issue May 18, 2020
@vrom911
[#251] Add 'ByteString' newtypes for Generic coding (#306)
37b1f6d 
Resolves #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
codec Conversion between TOML and custom user data types generics Generic bidirectional codecs good first issue Good for newcomers
Projects
None yet
Milestone
v1.3.0.0: Big update
Development

Successfully merging a pull request may close this issue.

[#251] Add 'ByteString' newtypes for Generic coding kowainik/tomland
2 participants
@chshersh @vrom911