Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Maps Codec #261

Closed
everythingfunctional opened this issue May 7, 2020 · 2 comments · Fixed by #269
Closed

Table Maps Codec #261

everythingfunctional opened this issue May 7, 2020 · 2 comments · Fixed by #269
Assignees
@everythingfunctional @chshersh @vrom911
Labels
codec Conversion between TOML and custom user data types
Milestone
v1.3.0.0: Big update

Comments

@everythingfunctional
Copy link
Contributor

This is a follow up to #254. #255 Solved the problem of dynamic keys if the values are simple values. But I need the values to be more complex than that. I need a way of specifying a codec for the values.
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 7, 2020
[kowainik#261] Dynamic keys with Codec values
b131ead
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 7, 2020
[kowainik#261] Dynamic keys with Codec values
5352b24
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 7, 2020
[kowainik#261] Dynamic keys with Codec values
9365ce1
@everythingfunctional
Copy link
Contributor Author

I came up with an approach in #262, but I think it's still not quite sufficient. What you'd really like to be able to specify is a codec that will work for simple values, tables or arrays, but this function so far only covers tables. I don't think the array case would be too difficult, but I'm not quite sure how to deal with the simple value case.

@chshersh chshersh added the codec Conversion between TOML and custom user data types label May 7, 2020
@chshersh
Copy link
Contributor

chshersh commented May 7, 2020

Sharing a link to a comment that explains use-case in detail:

@chshersh chshersh mentioned this issue May 8, 2020
Open
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 9, 2020
[kowainik#261] Dynamic keys with Codec values
ea58d1a
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 9, 2020
[kowainik#261] Dynamic keys with Codec values
f996ab4
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 9, 2020
[kowainik#261] Dynamic keys with Codec values
3e68135
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 12, 2020
[kowainik#261] Dynamic keys with Codec values
1f6bc08
everythingfunctional pushed a commit to everythingfunctional/tomland that referenced this issue May 12, 2020
[kowainik#261] Dynamic keys with Codec values
47f363d
@chshersh chshersh added this to the v1.3.0.0: Big update milestone May 13, 2020
chshersh added a commit that referenced this issue May 14, 2020
@chshersh
[#261] Dynamic Keys With Codec
c6364e6 
Resolves #261
@chshersh chshersh mentioned this issue May 14, 2020
Merged
@vrom911 vrom911 changed the title Dynamic Keys With Codec Table Maps Codec May 15, 2020
vrom911 pushed a commit that referenced this issue May 15, 2020
@chshersh
[#261] Table MapsCodec (#269)
536a5e6 
* [#261] Dynamic Keys With Codec

Resolves #261

* Fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@everythingfunctional everythingfunctional

@chshersh chshersh

@vrom911 vrom911

Labels
codec Conversion between TOML and custom user data types
Projects
None yet
Milestone
v1.3.0.0: Big update
Development

Successfully merging a pull request may close this issue.

[#261] Table MapsCodec kowainik/tomland
3 participants
@everythingfunctional @chshersh @vrom911