Allow to pass extra fields using --allow-extra-fields
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 11 21 +10
Lines 1020 2609 +1589
Branches 201 615 +414
===========================================
+ Hits 1020 2609 +1589
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fgebhart
force-pushed
the
allow_extra_fields_in_config
branch
from
6f0790a
to
c01e046
Compare
|
@fgebhart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thanks for this great tool! Hope you are okay with adding this little addition.
This PR introduces support for a feature request described in #785. As I found the code base super clean and the needed implementation rather straight forward, I'd like to contribute this change to your repo.
As it is my first time contributing to this tool, please pay attention to my naive implementation. Please also check whether I might have forgotten or overlooked something, as my perspective might be limited to my narrow use-case. And of course I'm open to all kind of suggestions.