Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move Field generation responsability to Resource #66

Merged
merged 1 commit into from
May 27, 2020
Merged

Refactor: Move Field generation responsability to Resource #66

merged 1 commit into from
May 27, 2020

Conversation

sdurban
Copy link
Contributor

@sdurban sdurban commented May 26, 2020

Coming from #64 .

Well I think the best place for generating Field object is in the every Resource (Connection handler), since every resource will be having their own conversions, what do you think?

@koxudaxi I normally don't code in Python so if something is "bad practice" just tell me.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          635       648   +13     
  Branches        79        79           
=========================================
+ Hits           635       648   +13     
Impacted Files Coverage Δ
local_data_api/models.py 100.00% <ø> (ø)
local_data_api/resources/jdbc/__init__.py 100.00% <100.00%> (ø)
local_data_api/resources/jdbc/mysql.py 100.00% <100.00%> (ø)
local_data_api/resources/jdbc/postgres.py 100.00% <100.00%> (ø)
local_data_api/resources/mysql.py 100.00% <100.00%> (ø)
local_data_api/resources/postgres.py 100.00% <100.00%> (ø)
local_data_api/resources/resource.py 100.00% <100.00%> (ø)
local_data_api/resources/sqlite.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6107892...cd4d6d9. Read the comment docs.

@koxudaxi koxudaxi merged commit dff7000 into koxudaxi:master May 27, 2020
@koxudaxi
Copy link
Owner

@sdurban

Well I think the best place for generating Field object is in the every Resource (Connection handler), since every resource will be having their own conversions, what do you think?

I agree It's very great.

@koxudaxi I normally don't code in Python so if something is "bad practice" just tell me.
no problem 👍

The version has been released as 0.4.13
Thank you for refactoring a lot of code 😄

@sdurban sdurban deleted the refactor_move_field_responsability branch May 27, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants