Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Fix wrong icon for system interpreter #127

Merged
merged 1 commit into from
Oct 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
<idea-plugin url="https://github.com/koxudaxi/poetry-pycharm-plugin">
<id>com.koxudaxi.poetry</id>
<name>Poetry</name>
<version>0.5.3</version>
<version>0.5.4</version>
<vendor email="koaxudai@gmail.com">Koudai Aono @koxudaxi</vendor>
<change-notes><![CDATA[
<h2>version 0.5.4</h2>
<p>Bug fixes</p>
<ul>
<li>Fix wrong icon for system interpreter [#127]</li>
</ul>
<h2>version 0.5.3</h2>
<p>Bug fixes</p>
<ul>
Expand Down
2 changes: 1 addition & 1 deletion src/com/koxudaxi/poetry/PoetrySdkProvider.kt
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class PoetrySdkProvider : PySdkProvider {
override fun getSdkAdditionalText(sdk: Sdk): String? = if (sdk.isPoetry) sdk.versionString else null

override fun getSdkIcon(sdk: Sdk): Icon? {
return POETRY_ICON
return if (sdk.isPoetry) POETRY_ICON else null
}

override fun loadAdditionalDataForSdk(element: Element): SdkAdditionalData? {
Expand Down
3 changes: 1 addition & 2 deletions src/com/koxudaxi/poetry/PyAddExistingPoetryEnvPanel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import com.jetbrains.python.sdk.add.PyAddSdkPanel
import com.jetbrains.python.sdk.add.PyAddSdkView
import com.jetbrains.python.sdk.add.PySdkPathChoosingComboBox
import com.jetbrains.python.sdk.add.addInterpretersAsync
import icons.PythonIcons
import java.awt.BorderLayout
import javax.swing.Icon

Expand All @@ -45,7 +44,7 @@ class PyAddExistingPoetryEnvPanel(private val project: Project?,
override var newProjectPath: String?,
context: UserDataHolder) : PyAddSdkPanel() {
override val panelName: String get() = PyBundle.message("python.add.sdk.panel.name.existing.environment")
override val icon: Icon = PythonIcons.Python.Virtualenv
override val icon: Icon = POETRY_ICON
private val sdkComboBox = PySdkPathChoosingComboBox()

init {
Expand Down
2 changes: 1 addition & 1 deletion src/com/koxudaxi/poetry/poetry.kt
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ fun createPoetryPanel(project: Project?,
else -> existingPoetryPanel
}
return PyAddSdkGroupPanel(Supplier { "Poetry environment" },
PythonIcons.Python.Virtualenv, panels, defaultPanel)
POETRY_ICON, panels, defaultPanel)
}


Expand Down