Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdiff 5.1.0 version #413

Closed
paultinker opened this issue Dec 12, 2023 · 1 comment
Closed

jsdiff 5.1.0 version #413

paultinker opened this issue Dec 12, 2023 · 1 comment

Comments

@paultinker
Copy link

Hi Kevin, Team,
The latest version of jsdiff is 5.1.0 as indicated on cdnjs and npm:

https://cdnjs.com/libraries/jsdiff
https://www.npmjs.com/package/diff/v/5.1.0

However, in the source on Github, the latest tag shows as 5.0.0

There are no tags or branches, that give an indication of the 5.1.0 version. Can you please advise as to the build details? Or in other words, where is the 5.1.0 version of jsdiff sourced?

Thank you - appreciate your time. Regards -Paul

@ExplodingCabbage
Copy link
Collaborator

This is the commit that the 5.1.0 build was generated from, I'm pretty sure: f4cc58c

(It's the last commit to reach master before the 5.1.0 release went out on npm, and looking at the code on npm confirms that it contains the options.maxEditLength feature added in that commit.)

I've pushed a tag now to reflect this. Thanks for catching!

(I guess we can infer that @kpdecker modified package.json locally to change the version number to 5.1.0 before uploading the release, but forgot to push the version number change to GitHub. Oops. Oh well!)

ExplodingCabbage added a commit that referenced this issue Dec 15, 2023
As @paultinker notes in #413, version 5.1.0 of jsdiff was released to npm last year, but the package.json in the repo still says we're on 5.0.0. Let's update the repo!
ExplodingCabbage added a commit that referenced this issue Dec 15, 2023
As @paultinker notes in #413, version 5.1.0 of jsdiff was released to npm last year, but the package.json in the repo still says we're on 5.0.0. Let's update the repo!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants