-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clvk stopped working on Android after adding buffer device address support #491
Comments
Fixes #491 Change-Id: I4c712a4c2da2edd59bcd893237b5cf13edb7392e Signed-off-by: Kévin Petit <kpet@free.fr>
@truboxl Thanks for the report! I didnt know you were packaging clvk for Android, that's great to see :). I've opened #496 which should fix the issue you're seeing. This issue will automatically close once the PR is merged as I'm very confident it fixes the issue described here but if that's not the case feel free to reopen the issue. Also, if there's anything we can do to help you package clvk on Android or provide a better user experience, don't hesitate to create further issues. Thanks! |
Hi @kpet
In this case API 31 translates to Android 12. Do you allow PR that workaround old Android version? Usually older version dont have the proper symbols in their system libvulkan.so. It maybe helpful to have at least some form of release version. This will be a great help for downstream distro to package clvk. Currently I am using some cryptic versioning while packaging clvk, eg: 0.0.20230218.101959gfb7b75ce 😂 |
…496) * Fix test build with non-loader Vulkan implementation Change-Id: I867b47c8b73f97495e7379b6958881f5214b444e * Do not assume vkGetBufferDeviceAddress is available to link against Fixes #491 Change-Id: I4c712a4c2da2edd59bcd893237b5cf13edb7392e Signed-off-by: Kévin Petit <kpet@free.fr> * format fixes Change-Id: I6c19b799c7c385113cb5759441abb04606017677 --------- Signed-off-by: Kévin Petit <kpet@free.fr>
Yes, definitely open to making changes so clvk can work with more Android versions. Feel free to create issues or open PRs. I can't promise someone would pick up the issues but it's always good to know what would be useful.
Yes, I agree we need to do better there :). I've created #499. Thoughts welcome! |
The latest commit 6ccb8a0 stopped working on my Android 11 device.
I am not sure whether its because of building clvk myself differently from the guide.
But using the older commit does work and I will temporarily revert my build to that commit.
I will checkout the GitHub Actions artifacts later to see if it can reproduce or not. (that thing is huge! ~2GB)
The text was updated successfully, but these errors were encountered: