Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proceed with the Django Girls tutorial #20

Open
webknjaz opened this issue Feb 7, 2021 · 7 comments
Open

Proceed with the Django Girls tutorial #20

webknjaz opened this issue Feb 7, 2021 · 7 comments
Assignees

Comments

@webknjaz
Copy link
Member

webknjaz commented Feb 7, 2021

Do a PR per each tutorial page or less, trying to identify atomic sets of changes or an easily reviewable size. For simplicity of tracking the progress, you may add a checkboxed markdown list here. Do your best to apply what you learned in the previous tasks.

https://tutorial.djangogirls.org/en/

The main objective here is not to blindly follow the tutorial (it has a lot of oversimplifications and the practices describe don't follow the real-world professional development standards) but to do better and practice development according to our GitHub Flow flavor in the environment of linters, tests and code reviews. We'll also do more integrations with other systems along the way.

@l1storez
Copy link
Collaborator

completed about 75%. It`s necessary to do a PR or checkboxes now? Because I forgot about this demand

@l1storez l1storez reopened this Jun 26, 2021
@webknjaz
Copy link
Member Author

It's best to send a series of small PRs.

@webknjaz
Copy link
Member Author

I've you've made one giant commit, you'll need to separate everything into atomic subsequent changes.

@l1storez
Copy link
Collaborator

I will make a "small project" and commit the changes according to tutorial pages. It's easier to implement for me

@webknjaz
Copy link
Member Author

I don't understand what you mean.

@l1storez
Copy link
Collaborator

Then I'll make branches and PR's for every tutorial page

@l1storez
Copy link
Collaborator

l1storez commented Jul 26, 2021

Progress:

@l1storez l1storez unpinned this issue Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants