Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] MainInstruction is confusing #6

Closed
RussKie opened this issue Feb 6, 2020 · 3 comments
Closed

[minor] MainInstruction is confusing #6

RussKie opened this issue Feb 6, 2020 · 3 comments

Comments

@RussKie
Copy link

RussKie commented Feb 6, 2020 •
edited
Loading

During an internal usability study for the TaskDialog API, all users found MainInstruction name unclear and confusing.

- To me instruction is a paragraph, not the heading. Maybe I'll call it Header
- MainInstruction was not clear. I'd rather call it Heading

We had an internal discussion and resolved that we shouldn’t necessarily align our naming to underlying Win32 API if it causes confusion for Windows Forms users.
@kpreisser
Copy link
Owner

I think I would rename it to Heading.
(I think Header would be similar to Footer and would imply that it's a separate area like the footer, but actually it's only a text line.)

kpreisser added a commit that referenced this issue Apr 8, 2020
@kpreisser
Rename property TaskDialogPage.MainInstruction to Heading.
f00f2ae 
Fixes #6
@kpreisser
Copy link
Owner

I renamed the property to Heading.

@RussKie
Copy link
Author

RussKie commented Apr 8, 2020

Awesome. thank you

@kpreisser kpreisser mentioned this issue Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RussKie @kpreisser