Rework task dialog button API #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove enums TaskDialogResult and TaskDialogButtons - Replace existing button classes with TaskDialogButton and TaskDialogCommandLinkButton - Create static "factory properties" that return new instances of TaskDialogButton representing a standard (common) button - Change static ShowDialog() methods to allow to pass an IEnumerable<TaskDialogButton> and return a TaskDialogButton Fixes #5
…was caused by our own code sending a TDM_CLICK_BUTTON message.
…ve the TaskDialogResult value of the button, and add a few CustomN enum values.
…o retrieve the TaskDialogResult value of the button, and add a few CustomN enum values." This reverts commit 6a73a75.
* Shift the default button assignment to the dialog The original design allowed a user to mark multiple buttons as default. In this situation there will be a RTE, which is not the best devex/UX. Shift assignment of the default button to the dialog. This way the API are similar to the MessageBox API, and the user is able to assign onle one button. If the button doesn't belong to the collection of buttons - there will be a RTE.
…er/winforms into taskdialogRefactorButton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the public button API:
Fixes #5