Simplify setting dialog icon from bitmaps #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
commented
Mar 24, 2020
src/System.Windows.Forms/src/System/Windows/Forms/TaskDialogIcon.cs
Outdated
Show resolved
Hide resolved
RussKie
force-pushed
the
Simplify_set_icon_from_bitmap
branch
from
37a759d
to
2e8fbe9
Compare
kpreisser
reviewed
Mar 26, 2020
src/System.Windows.Forms/src/System/Windows/Forms/TaskDialogPage.cs
Outdated
Show resolved
Hide resolved
kpreisser
reviewed
Apr 2, 2020
src/System.Windows.Forms/src/System/Windows/Forms/TaskDialogIcon.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/TaskDialogIcon.cs
Outdated
Show resolved
Hide resolved
Typically images are used from Resources, and those are of `Bitmap` type.
The existing API only takes `Icon` that requires additional work from a
developer, which wouldn't be straight forward for a significant part of
the development community, e.g.:
new TaskDialogIcon(Icon.FromHandle(Properties.Resources.Network.GetHicon()))
Provide an overload that takes a `Bitmpa` and handles the necessary plumbing.
RussKie
force-pushed
the
Simplify_set_icon_from_bitmap
branch
from
705d861
to
94ca1a3
Compare
|
Updated |
|
Thanks a lot! |
|
Looks like we'll need to implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically images are used from Resources, and those are of
Bitmaptype.The existing API only takes
Iconthat requires additional work from a developer, which wouldn't be straight forward for a significant part of the development community, e.g.:Provide an overload that takes a
Bitmpaand handles the necessary plumbing.