Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dialog properties via ShowDialog #16

Conversation

RussKie
Copy link

@RussKie RussKie commented Mar 24, 2020

TaskDialog had two properties StartupLocation and SetToForeground that could no longer be set after Page API were streamlined and instance-based methods were removed.

Allow developers to pass these two properties when invoking the dialog.

Relates to #14

TaskDialog had two properties `StartupLocation` and `SetToForeground`
that could no longer be set after `Page` API were streamlined and
instance-based methods were removed.

Allow developers to pass these two properties when invoking the dialog.
@kpreisser
Copy link
Owner

Hi @RussKie, thanks for doing the PR!
In #13, you mentioned that we should remove the SetToForeground flag for now. Do you still want to add it as in this PR?

@RussKie
Copy link
Author

RussKie commented Apr 1, 2020

In #13, you mentioned that we should remove the SetToForeground flag for now. Do you still want to add it as in this PR?

Good call, I forgot about it :)
Done

Copy link
Owner

@kpreisser kpreisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kpreisser kpreisser merged commit dd3b7de into kpreisser:taskdialog Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants