Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Testing Environment for Kpt Live Tests #1492

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

runewake2
Copy link
Contributor

Introduces a workflow that configures a KinD cluster for use with end-to-end.sh and runs those tests against the cluster. An example of the results from this execution is here.

Notes:

  • This test is still triggered manually (navigate to Actions, select the workflow and choose to run it).
  • This test may never fail. (the test script does not exit with an error so test failures are only displayed in workflow logs)

The intent is to resolve both of these in follow up PR's, in the meantime this will enable new tests to be run in this environment.

This uses https://github.com/engineerd/setup-kind to configure the KinD environment (downloading and installing KinD). I've fixed the action to a specific commit SHA (setup-kind v0.5.0) following GitHub's recommendations.

Related to issue: #1387

@runewake2
Copy link
Contributor Author

I've added some additional changes that will cause end-to-end-test.sh to exit if a test does not pass. This should allow us to get feedback in these automated tests.

Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mortent
Copy link
Contributor

mortent commented Feb 25, 2021

This looks good to me but why not run it on every PR?

@runewake2
Copy link
Contributor Author

I am running this manually right now to confirm it behaves well, once that's been done checks on pushes to master/next and pulls against those branches will be added. Doing this in stages should help prevent any potential errors from blocking unrelated PR's.

@runewake2 runewake2 merged commit a1679f7 into kptdev:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants