make eval to use kpt container & exec runtime #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
approved these changes
May 5, 2021
| @@ -17,5 +17,4 @@ exitCode: 1 | |||
| image: gcr.io/kpt-fn/dne # non-existing image | |||
| args: | |||
| namespace: staging | |||
| stdErr: "Failed to fetch \"latest\" from request \"/v2/kpt-fn/dne/manifests/latest\"" | |||
|
|
|||
| stdErr: 'failed to check function image existence: function image "gcr.io/kpt-fn/dne" doesn''t exist' | |||
There was a problem hiding this comment.
Not this PR: Can we remove this failed to check function image existence part from the error ?
There was a problem hiding this comment.
We probably need to define a struct for this error?
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* change eval to use kpt container runtime * make eval to use kpt exec runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn evalis using container and exec runtime from kyaml. These runtimes are hardcoding the command error outputs toos.Stderrso we cannot get the stderr output from the runtime.One alternative is refactoring the kyaml implementation to accept a writer for stderr. However, given we have had our own container runtime in kpt and is used by
render. It's better to makeevalandrenderto use the same runtime.This PR is modifying the container runtime in kpt to support the functionalities required by
fn evaland adding an exec runtime forfn eval.