Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include stderr in results when function succeeds #2214

Merged
merged 2 commits into from
Jun 14, 2021
Merged

include stderr in results when function succeeds #2214

merged 2 commits into from
Jun 14, 2021

Conversation

Shell32-Natsu
Copy link
Contributor

close #2200

@Shell32-Natsu Shell32-Natsu linked an issue Jun 10, 2021 that may be closed by this pull request
Kpt fn render swallows stderr output when exit code is 0 #2200
Closed
droot
droot requested changes Jun 10, 2021
View reviewed changes
internal/fnruntime/container.go Outdated Show resolved Hide resolved
internal/fnruntime/runner.go Outdated Show resolved Hide resolved
e2e/testdata/fn-eval/fn-success-with-stderr/starlark.yaml Outdated Show resolved Hide resolved
@Shell32-Natsu Shell32-Natsu merged commit 3578c9b into kptdev:main Jun 14, 2021
@Shell32-Natsu Shell32-Natsu deleted the stderr branch June 14, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@frankfarzan frankfarzan Awaiting requested review from frankfarzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kpt fn render swallows stderr output when exit code is 0
3 participants
@Shell32-Natsu @droot @frankfarzan