Generate sitemap on site deployment. #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfarzan
suggested changes
Jun 25, 2021
| @@ -15,13 +15,7 @@ | |||
| name: Check Licenses | |||
| on: | |||
There was a problem hiding this comment.
do you want just "on: [push, pull_request]"?
How about other workflows? #2229
There was a problem hiding this comment.
Changed to just pull_request for all workflows bar releasing the tool or deploying the site. None of the workflows that check for a pristine state modify the state of the repo after merging a PR, so this should be sufficient until that's no longer the case.
There was a problem hiding this comment.
I think you want workflows to run on push. This visually ends up as a green check mark on the branch.
There was a problem hiding this comment.
Added for the sake of validation.
droot
approved these changes
Jun 28, 2021
frankfarzan
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2273 by providing a
sitemap.xmlto be indexed by search console tools once it's hosted on kpt.devFixes #1662 by relatedly prioritizing kpt.dev results over the old documentation site (already blocked on search)
Fixes #2229 by removing branch specificity on all workflows that check the validity of content (docs, licenses, site) to be picked up on branches of
main. Workflows that testkptdirectly also have no branch specificity to ensure legacy branches ofmaindon't experience regressions but also ignore changes to docs or site content.