Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Porch Build #2672

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fix Porch Build #2672

merged 2 commits into from
Jan 27, 2022

Conversation

martinmaly
Copy link
Contributor

Location of ClonerUsingGitExec changed in the OCI branch.

Location of ClonerUsingGitExec changed in the OCI branch.
@@ -0,0 +1,43 @@
# Copyright 2022 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does github run the workflows from the target branch (or do we need to restrict to the porch branch?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell it runs them in the target branch.

@justinsb
Copy link
Contributor

One question, but lgtm

/approve
/lgtm

@martinmaly martinmaly merged commit 2a3d1da into kptdev:porch Jan 27, 2022
@martinmaly martinmaly deleted the build branch January 27, 2022 18:35
martinmaly added a commit to martinmaly/kpt that referenced this pull request Feb 18, 2022
* Fix Porch Build

Location of ClonerUsingGitExec changed in the OCI branch.

* Add Porch Workflow
martinmaly added a commit to martinmaly/kpt that referenced this pull request Feb 18, 2022
* Fix Porch Build

Location of ClonerUsingGitExec changed in the OCI branch.

* Add Porch Workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants