Surface failure information from pod evaluator #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengqiy
requested review from
droot,
justinsb,
martinmaly,
mortent,
natasha41575 and
yuwenma
as code owners
mengqiy
commented
May 6, 2022
porch/func/wrapper-server/main.go
Outdated
|
|
||
| // TODO: replace this with fn.ParseResourceList when github.com/GoogleContainerTools/kpt-functions-sdk/go/fn in go.mod | ||
| // is upgraded to cdc9f0cfea190d80397dc05e2b514b2ba1c89b6c or later. | ||
| func parseResults(resourceList []byte) (fn.Results, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface more failure information to users when:
Added a e2e test to exercise the failure scenario in pod evaluator.