Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller-oriented RESTMapper in porch controllers #3567

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Sep 21, 2022

We want to try this out, should be much faster and lighter on the apiserver.

This is code that we're trying the "copy and paste" reuse approach until we find the right library, copied from https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/tree/master/pkg/restmapper . That code is also Apache licensed and I am the original author.

We want to try this out, should be much faster and lighter on the
apiserver.
}
return &meta.RESTMapping{
Resource: c.gv.WithResource(cached.Resource),
GroupVersionKind: c.gv.WithKind(kind),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was wondering the other day how to use the gvk functions with more flexibility.

Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. may defer to @mortent for final approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants