Fix failing fn-eval test #4156
Merged
Fix failing fn-eval test #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format was changed in upstream kyaml/fn version in kubernetes-sigs/kustomize#4727. Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
I had issues running tests since it was using my custom settings for `git diff`, resulting in mismatch when evaluating diffs. I also had to prefix my commands with `env DOCKER_DEFAULT_PLATFORM=linux/amd64` because I'm on Apple Silicon. Otherwise, the warning output for platform mismatch also resulted in false negatives. Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
fsommar
force-pushed
the
fix-failing-fn-eval-test
branch
from
031cc65
to
9792ad3
Compare
|
/assign @mortent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #4129 which blocks the main branch from building due to a failing test. It also removes the porch files again as they were mistakenly included after a rebase.