Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python module #2

Merged
merged 5 commits into from
Jul 4, 2012
Merged

python module #2

merged 5 commits into from
Jul 4, 2012

Conversation

vchahun
Copy link
Contributor

@vchahun vchahun commented Jul 4, 2012

  • not using binary LM anymore
  • I converted README to markdown, keep it if you like...

@kpu
Copy link
Owner

kpu commented Jul 4, 2012

Stupid question: should that auto-generated kenlm.cpp be part of the source code?

kpu added a commit that referenced this pull request Jul 4, 2012
@kpu kpu merged commit 723ec61 into kpu:master Jul 4, 2012
@vchahun
Copy link
Contributor Author

vchahun commented Jul 4, 2012

Yes, this is the recommendation from cython:
http://docs.cython.org/src/userguide/source_files_and_compilation.html#distributing-cython-modules

This allows installation without cython. When the cython source is modified, you just need to run:

cython --cplus python/kenlm.pyx

@hieuhoang
Copy link
Collaborator

Hi victor,

I'm revelling at the moment so not able to look at your fork. What's
the difference between yours and ken's version?

If u have some useful contribution you're better off telling ken to
merge it with his version. I don't control that part of Moses

Hieu
Sent from my flying horse

On 4 Jul 2012, at 02:43 AM, Victor Chahuneau
reply@reply.github.com
wrote:

  • not using binary LM anymore
  • I converted README to markdown, keep it if you like...

You can merge this Pull Request by running:

git pull https://github.com/vchahun/kenlm master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

  • Add python module; supports LM querying
  • Some instructions
  • Fix for g++ and python 3
  • [python] Change to non-binary LM in example; catch C++ exception
  • Merge READMEs

-- File Changes --

R README.md (44)
A examples/example.py (26)
A python/kenlm.cpp (3436)
A python/kenlm.pxd (28)
A python/kenlm.pyx (65)
A setup.py (24)

-- Patch Links --

https://github.com/kpu/kenlm/pull/2.patch
https://github.com/kpu/kenlm/pull/2.diff


Reply to this email directly or view it on GitHub:
#2

@kpu
Copy link
Owner

kpu commented Jul 4, 2012

Hi Hieu,

This was a pull request for kenlm that I asked Victor to make.  You 

have commit access to kenlm, so github spammed you. It's not the
mosesdecoder project.

Kenneth

On 07/04/2012 08:47 AM, Hieu Hoang wrote:

Hi victor,

I'm revelling at the moment so not able to look at your fork. What's
the difference between yours and ken's version?

If u have some useful contribution you're better off telling ken to
merge it with his version. I don't control that part of Moses

Hieu
Sent from my flying horse

On 4 Jul 2012, at 02:43 AM, Victor Chahuneau
reply@reply.github.com
wrote:

  • not using binary LM anymore
  • I converted README to markdown, keep it if you like...

You can merge this Pull Request by running:

git pull https://github.com/vchahun/kenlm master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

  • Add python module; supports LM querying
  • Some instructions
  • Fix for g++ and python 3
  • [python] Change to non-binary LM in example; catch C++ exception
  • Merge READMEs

-- File Changes --

R README.md (44)
A examples/example.py (26)
A python/kenlm.cpp (3436)
A python/kenlm.pxd (28)
A python/kenlm.pyx (65)
A setup.py (24)

-- Patch Links --

https://github.com/kpu/kenlm/pull/2.patch
https://github.com/kpu/kenlm/pull/2.diff


Reply to this email directly or view it on GitHub:
#2


Reply to this email directly or view it on GitHub:
#2 (comment)

@hieuhoang
Copy link
Collaborator

oh, damn this conniving github & all it's offsprings

On 4 July 2012 14:12, Kenneth Heafield <
reply@reply.github.com

wrote:

Hi Hieu,

    This was a pull request for kenlm that I asked Victor to make.  You

have commit access to kenlm, so github spammed you. It's not the
mosesdecoder project.

Kenneth

On 07/04/2012 08:47 AM, Hieu Hoang wrote:

Hi victor,

I'm revelling at the moment so not able to look at your fork. What's
the difference between yours and ken's version?

If u have some useful contribution you're better off telling ken to
merge it with his version. I don't control that part of Moses

Hieu
Sent from my flying horse

On 4 Jul 2012, at 02:43 AM, Victor Chahuneau
reply@reply.github.com
wrote:

  • not using binary LM anymore
  • I converted README to markdown, keep it if you like...

You can merge this Pull Request by running:

git pull https://github.com/vchahun/kenlm master

Or you can view, comment on it, or merge it online at:

#2

-- Commit Summary --

  • Add python module; supports LM querying
  • Some instructions
  • Fix for g++ and python 3
  • [python] Change to non-binary LM in example; catch C++ exception
  • Merge READMEs

-- File Changes --

R README.md (44)
A examples/example.py (26)
A python/kenlm.cpp (3436)
A python/kenlm.pxd (28)
A python/kenlm.pyx (65)
A setup.py (24)

-- Patch Links --

https://github.com/kpu/kenlm/pull/2.patch
https://github.com/kpu/kenlm/pull/2.diff


Reply to this email directly or view it on GitHub:
#2


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@cffan cffan mentioned this pull request Sep 26, 2014
frankier pushed a commit to frankier/kenlm that referenced this pull request Mar 28, 2024
…1_h3100fc

Rebuild for PyPy3.8 and PyPy3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants