allow gcc 4.8 to compile kenlm #6
Merged
+72
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make ProxyIterator::reference a reference (not a value) in order to truly satisfy random access iterator requirements, because std algs were trying to std::swap rvalues added swap(ProxyIterator &,ProxyIterator &) and (shallow) swap of SizedProxy.Inner() to go with existing deep swap for SizedProxy; I know there are other ProxyIterators but the code I'm building doesn't need swap for those. added a //TODO: comment with a concern I have about SizedProxy's deep swap (which was only recently added); I (graehl) don't understand KenLM well enough to judge. avoid some new gcc 4.8 warnings made compile_query_only.sh respect CXX env var
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make ProxyIterator::reference a reference (not a value) in order to truly
satisfy random access iterator requirements, because std algs were trying to
std::swap rvalues
added swap(ProxyIterator &,ProxyIterator &) and (shallow) swap of
SizedProxy.Inner() to go with existing deep swap for SizedProxy; I know there
are other ProxyIterators but the code I'm building doesn't need swap for
those. added a //TODO: comment with a concern I have about SizedProxy's deep
swap (which was only recently added); I (graehl) don't understand kenlm well
enough to judge.
avoid some new gcc 4.8 warnings
made compile_query_only.sh respect CXX env var