Adds a failing test for time output based on encoding.TextMarshaler #17
Conversation
| func TestTime(t *testing.T) { | ||
| date := time.Date(2006, 1, 2, 3, 4, 5, .678901e9, time.Local) | ||
| d, _ := date.MarshalText() | ||
| s := fmt.Sprintf("%# v", Formatter(date)) |
There was a problem hiding this comment.
You could write this as Sprintf("%# v", date).
There was a problem hiding this comment.
OTOH, I guess all the other ones in this file already use fmt, so might as well be consistent.
There was a problem hiding this comment.
I won't have time to dive into a fix for this right away. Not a pain point for me, but I had the itch to at least reproduce it. Another dev on my team hit it once and also didn't provide steps to reproduce, so I had to scratch that itch.
On Sep 29, 2014, at 22:04, Keith Rarick notifications@github.com wrote:
In formatter_test.go:
@@ -259,3 +260,13 @@ func TestCycle(t *testing.T) {
*iv = *i
t.Logf("Example long interface cycle:\n%# v", Formatter(i))
}
+
+func TestTime(t *testing.T) {
- date := time.Date(2006, 1, 2, 3, 4, 5, .678901e9, time.Local)
- d, _ := date.MarshalText()
- s := fmt.Sprintf("%# v", Formatter(date))
I guess all the other ones in this file already use fmt, so might as well be consistent.—
Reply to this email directly or view it on GitHub.
Incomplete: needs implementation.