Fix MIT license for pkg.go.dev; tidy go.mod and create go.sum #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the documentation for github.com/kr/pretty is not displayed on
pkg.go.dev because of license restrictions:
https://pkg.go.dev/github.com/kr/pretty?tab=doc
This is almost certainly because the License file includes an errant
header:
The MIT License (MIT)
The actual MIT license does not include this header:
https://opensource.org/licenses/MIT
GitHub and other interfaces surface the type of the license through
automatic detection (as will pkg.go.dev). Hence this header is
superfluous in any case.
Whilst we are at it, tidy up go.mod and add go.sum.
|
Sweet, thanks! |
|
Thanks. You're going to need to cut a new version for pkg.go.dev to see the changes |
As a data point, this LICENSE file gets recognized as the MIT license (see https://pkg.go.dev/github.com/shurcooL/httpfs?tab=licenses), but its header is a shorter "MIT License" text from https://choosealicense.com/licenses/mit/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the documentation for github.com/kr/pretty is not displayed on
pkg.go.dev because of license restrictions:
This is almost certainly because the License file includes an errant
header:
The actual MIT license does not include this header:
GitHub and other interfaces surface the type of the license through
automatic detection (as will pkg.go.dev). Hence this header is
superfluous in any case.
Whilst we are at it, tidy up go.mod and add go.sum.