Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query strings are now being passed to backends #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Query strings are now being passed to backends #5

wants to merge 1 commit into from

Conversation

rhyselsmore
Copy link

$ go test
warning: building out-of-date packages:
    github.com/kr/spdy/spdyframing
installing these packages with 'go test -i' will speed future tests.

PASS
ok      _/Users/relsmore/Development/spdy   0.085s

Haven't added in tests for query strings yet, just edited the current tests to support the header.

@kr
Copy link
Owner

kr commented Aug 8, 2013

Hey, somehow I missed this actual PR until now.
We can't just add a :query field, since it's not part
of SPDY. Query params have to go in as part of :path.
That part should be taken care of in a4f7cf4.
But we still need to get the query params back out again.
I suspect calling url.Parse on the path will do what we
want, then we can fill in Scheme and Host.

If you want to redo this PR, go for it.
Otherwise I can take care of it.

@rhyselsmore
Copy link
Author

I will redo it when I hit LA in 14 hours. Thanks for the guidance :)

@kr
Copy link
Owner

kr commented Aug 8, 2013

Wow a4f7cf4 didn't even have a test for query params.
Added in b6b3b6c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants