Non-zero exit code on run_job failure #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Jul 20, 2019
| method_to_call.assert_called_with(1, 'two', test=34, a='s2') | ||
|
|
||
|
|
||
| @override_settings(CRONJOBS=[('*/1 * * * *', 'tests.cron.cron_job', [1, 'two'], dict(), 'some suffix')]) | ||
| @patch('tests.cron.cron_job') | ||
| def test_run_args_only_format2_job(method_to_call): | ||
| def test_run_args_only_format3_job(method_to_call): |
There was a problem hiding this comment.
I got warnings about this being a duplicate name with the above test, so I renamed it
palfrey
commented
Jul 20, 2019
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| from django_crontab.app_settings import Settings | |||
|
|
|||
| string_type = basestring if sys.version_info[0] == 2 else str # flake8: noqa | |||
| string_type = basestring if sys.version_info[0] == 2 else str # noqa: F821 | |||
There was a problem hiding this comment.
Not quite sure why this was now failing, as it's got nothing to do with my changes. Changing to an explicit ignore seems to work fine
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99