add onkrakenmount property; removed node v4, v6 and added node 10 in travis CI config #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarrishav
changed the title
|
@tlivings @aheckmann @grawk @shaunwarman review? |
kumarrishav
changed the title
lib/bootstrap.js
Outdated
| @@ -27,6 +27,10 @@ var debug = require('debuglog')('kraken/bootstrap'); | |||
|
|
|||
| module.exports = function (app, options) { | |||
|
|
|||
| // on bootstrapinit | |||
| const onbootstrapinit = options.onbootstrapinit; | |||
There was a problem hiding this comment.
My understanding is that this is invoked when kraken is mounted in an express app and express app instance is available to pass down the callback function. Thoughts on calling this as onkrakenmount or onmount?
kumarrishav
changed the title
grawk
requested changes
Nov 26, 2019
kumarrishav
changed the title
sumeetkakkar
reviewed
Dec 9, 2019
test/kraken.js
Outdated
|
|
||
| options = { | ||
| onkrakenmount: function (app) { | ||
| const serverListen = app.listen; |
There was a problem hiding this comment.
I think we should just assert that the app is an express instance.
grawk
approved these changes
Jan 17, 2020
sumeetkakkar
approved these changes
Jan 17, 2020
snowinferno
reviewed
Jan 21, 2020
snowinferno
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving the implementation details from #513
This will let have modules the app instance once Kraken (express sub-app) mounts.