Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makara 2 and Dust @provide helper #76

Closed
connesc opened this issue Oct 1, 2015 · 3 comments · Fixed by #84
Closed

Makara 2 and Dust @provide helper #76

connesc opened this issue Oct 1, 2015 · 3 comments · Fixed by #84
Assignees

Comments

@connesc
Copy link

connesc commented Oct 1, 2015

I recently upgraded a Kraken project to Makara 2, and I discovered that the combination of mode="paired" and @provide does not work anymore.

I took me a while to figure out that @provide (from dustmotes-provide) is not able to consume the output of @message. I think that this breaking change should be mentioned somewhere (at least in this page).

If anyone is interested, I solved the problem by writing my own @provide helper: dust-provide-helper. It is not perfect, but it can be used as a drop-in replacement for dustmotes-provide with Makara 2.

@grawk
Copy link
Member

grawk commented Jan 28, 2016

Sorry for the delay. I will be looking into this.

@grawk
Copy link
Member

grawk commented Jul 11, 2016

Hi @connesc I'm investigating this now. I see that your new helper code does work in paired mode while the original @provide helper code does not. I've forked the @provide helper (and other dustmotes helpers) into the krakenjs org (as https://github.com/krakenjs/festucam) in order that we can keep them up to date. The original author has retired and I think this is the best way to support them going forward. Would you mind opening a PR against festucam with your changes? If you're not actively working on dust anymore, I'm happy to open the PR myself and add you as a "contributor" in package.json. Let me know.

@connesc
Copy link
Author

connesc commented Jul 14, 2016

Hi @grawk, and thanks for this follow up.
Your PR looks good to me, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants