Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added events on prerender start and finish #403

Merged
merged 2 commits into from
May 3, 2022

Conversation

rubenfig
Copy link
Contributor

@rubenfig rubenfig commented May 2, 2022

Added event triggers for prerender steps.
Feature required on #402

@rubenfig rubenfig requested a review from a team as a code owner May 2, 2022 22:31
@bluepnume
Copy link
Collaborator

Looks good! Can we get a couple of tests please

@rubenfig
Copy link
Contributor Author

rubenfig commented May 2, 2022

@bluepnume Added some tests, let me know if something else is needed

@codecov-commenter
Copy link

Codecov Report

Merging #403 (3c957e6) into main (a085f40) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   95.51%   95.53%   +0.01%     
==========================================
  Files          18       18              
  Lines        1182     1186       +4     
==========================================
+ Hits         1129     1133       +4     
  Misses         53       53              
Impacted Files Coverage Δ
src/component/props.js 93.93% <ø> (ø)
src/constants.js 100.00% <ø> (ø)
src/parent/parent.js 95.38% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a085f40...3c957e6. Read the comment docs.

Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @rubenfig! 💯

@gregjopa gregjopa merged commit c603048 into krakenjs:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants