Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #72

Merged
merged 4 commits into from
May 5, 2023
Merged

Improve logging #72

merged 4 commits into from
May 5, 2023

Conversation

godsic
Copy link
Contributor

@godsic godsic commented Apr 10, 2023

THIS SHOULD BE MERGED AFTER #65

  • Log GPS timestamps, as it might be beneficial for data synchronization purposes among networked devices.
  • Log timestamps in UTC.
  • Acquire position, heading and GPS timestamp as close to measurement as possible.
  • Refactor data writers (a) to be called after all processing is done and (b) to use common timestamp.
  • Report actual latency to the clients.
  • When acquiring GPS heading, make sure it is moving faster than the user-defined threshold (2 m/s by default) for a user-defined minimum amount of time (3 s by default).
  • Serve last succesful DoA estimate when squelch is used.
  • Report additional signal metrics:
    There might be certain conditions where DoA estimation might not be trustworthy. Those include ADC overdrive (due to strong signal or excesive gain), correlated signals (e.g., due to multipath) and low SNR of a signal-of-interest. So lets communicate them with clients, so that they can make informed decision on appropriate DoA data filtering.

This was referenced Apr 10, 2023

if self.data_ready and self.theta_0_list:
# Do Kraken App first as currently its the only one supporting multi-vfo out
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange if ( formating, it is not python way. Python IDE and extensions could complain on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing, because looks like it is okay according the PEP-8

godsic added a commit to godsic/df-aggregator that referenced this pull request Apr 15, 2023
Instead keep the last know measurement and plot corresponding lob in
gray color to alert operator. This change is suggested to be used
together with krakenrf/krakensdr_doa#72 .
- Log GPS timestamps, as it might be beneficial for data synchronization
  purposes among networked devices.
- Log timestamps in UTC.
- Acquire position, heading and GPS timestamp as close to measurement as
  possible.
- Refactor data writers (a) to be called after all processing is done
  and (b) to use common timestamp.
- Report actual latency and processing time to the clients.
- When acquiring GPS heading, make sure it is moving faster than the
  threshold (currently 2 m/s) for a minimum amount of time (currently
  3s).
- Serve last succesful DoA estimate when squelch is used.
- Report additional signal metrics:
  There might be certain conditions where DoA estimation might not be
  trustworthy. Those include ADC overdrive (due to strong signal or
  excesive gain), correlated signals (e.g., due to multipath) and low
  SNR of a signal-of-interest. So lets communicate them with clients,
  so that they can make informed decision on DoA data filtering.
@krakenrf krakenrf merged commit c1bbcf5 into krakenrf:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants