Improve logging #72
Merged
Improve logging #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2023
Closed
redradist
reviewed
Apr 11, 2023
|
|
||
| if self.data_ready and self.theta_0_list: | ||
| # Do Kraken App first as currently its the only one supporting multi-vfo out | ||
| if ( |
There was a problem hiding this comment.
It is strange if ( formating, it is not python way. Python IDE and extensions could complain on it
There was a problem hiding this comment.
Closing, because looks like it is okay according the PEP-8
godsic
force-pushed
the
feature/gps-timestamps
branch
from
45dd6b3
to
6194719
Compare
godsic
added a commit
to godsic/df-aggregator
that referenced
this pull request
Apr 15, 2023
Instead keep the last know measurement and plot corresponding lob in gray color to alert operator. This change is suggested to be used together with krakenrf/krakensdr_doa#72 .
godsic
force-pushed
the
feature/gps-timestamps
branch
from
6194719
to
c0883e4
Compare
- Log GPS timestamps, as it might be beneficial for data synchronization purposes among networked devices. - Log timestamps in UTC. - Acquire position, heading and GPS timestamp as close to measurement as possible. - Refactor data writers (a) to be called after all processing is done and (b) to use common timestamp. - Report actual latency and processing time to the clients. - When acquiring GPS heading, make sure it is moving faster than the threshold (currently 2 m/s) for a minimum amount of time (currently 3s). - Serve last succesful DoA estimate when squelch is used. - Report additional signal metrics: There might be certain conditions where DoA estimation might not be trustworthy. Those include ADC overdrive (due to strong signal or excesive gain), correlated signals (e.g., due to multipath) and low SNR of a signal-of-interest. So lets communicate them with clients, so that they can make informed decision on DoA data filtering.
godsic
force-pushed
the
feature/gps-timestamps
branch
from
c0883e4
to
c0bfd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS SHOULD BE MERGED AFTER #65
There might be certain conditions where DoA estimation might not be trustworthy. Those include ADC overdrive (due to strong signal or excesive gain), correlated signals (e.g., due to multipath) and low SNR of a signal-of-interest. So lets communicate them with clients, so that they can make informed decision on appropriate DoA data filtering.