Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Docker Hub with GitHub Container Registry #298

Merged
merged 6 commits into from
May 16, 2024

Conversation

flavioheleno
Copy link
Contributor

As discussed in #297, this PR replaces all https://hub.docker.com/u/parallelphp images with ghcr.io/krakjoe.

It also adds a new workflow called "docker" that builds such images.

Closes #297.

@flavioheleno
Copy link
Contributor Author

@realFlowControl the pipeline will fail due to both b57b811 and 8814dfd requiring the images that are built by a1ea32e. I can split this PR in two parts to avoid this if you think it is a better approach.

@realFlowControl realFlowControl self-assigned this May 16, 2024
Co-authored-by: Florian Engelhardt <flo@dotbox.org>
@flavioheleno
Copy link
Contributor Author

You may need to manage write and read access of GitHub Actions for packages in the repository settings.

@realFlowControl
Copy link
Collaborator

Nargh crap, I do not have these access rights in the repo here to do that. I try and reach out to @krakjoe and see if he can enable this (or alternatively grant me access to DockerHub, although I'd favour the GitHub Registry).

@realFlowControl
Copy link
Collaborator

Got it, the problem was that {{ github.actor }} is the user that initially triggered the workflow, in that case you, but you do not have the corresponding rights. So I pushed your .github/workflows/docker.yml to the develop branch and manually triggered the run at https://github.com/krakjoe/parallel/actions/runs/9112014983 some builds are still failing ...

@realFlowControl
Copy link
Collaborator

Hmm, restarting the failed tests helps, might be a race condition, but we should definitely check if the containers are correct or if there is a collision somehow

@realFlowControl
Copy link
Collaborator

@flavioheleno we might need to add an authentication step

@flavioheleno
Copy link
Contributor Author

@flavioheleno we might need to add an authentication step

to asan and linux workflows, right?

@realFlowControl
Copy link
Collaborator

I think so, lets try it

@flavioheleno
Copy link
Contributor Author

Success :)

@realFlowControl realFlowControl merged commit 6923741 into krakjoe:develop May 16, 2024
39 checks passed
@realFlowControl
Copy link
Collaborator

realFlowControl commented May 16, 2024

Whoop Whoop, that is so awesome!
Thank you very much for stepping up @flavioheleno 🎉

Regarding the other PRs you had open, feel free to update those, but beware that I'll be on vacation from Saturday on and will not be able to review/merge anything.

@flavioheleno
Copy link
Contributor Author

no worries, it's important to take some time off. I'll update them and leave them sit here until you're able to take a look.

@flavioheleno flavioheleno deleted the fix/pipeline branch May 16, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub workflow depends on Docker Hub
2 participants