-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Docker Hub with GitHub Container Registry #298
Conversation
@realFlowControl the pipeline will fail due to both b57b811 and 8814dfd requiring the images that are built by a1ea32e. I can split this PR in two parts to avoid this if you think it is a better approach. |
Co-authored-by: Florian Engelhardt <flo@dotbox.org>
You may need to manage write and read access of GitHub Actions for packages in the repository settings. |
Nargh crap, I do not have these access rights in the repo here to do that. I try and reach out to @krakjoe and see if he can enable this (or alternatively grant me access to DockerHub, although I'd favour the GitHub Registry). |
Got it, the problem was that |
Hmm, restarting the failed tests helps, might be a race condition, but we should definitely check if the containers are correct or if there is a collision somehow |
@flavioheleno we might need to add an authentication step |
to asan and linux workflows, right? |
I think so, lets try it |
Success :) |
Whoop Whoop, that is so awesome! Regarding the other PRs you had open, feel free to update those, but beware that I'll be on vacation from Saturday on and will not be able to review/merge anything. |
no worries, it's important to take some time off. I'll update them and leave them sit here until you're able to take a look. |
As discussed in #297, this PR replaces all https://hub.docker.com/u/parallelphp images with ghcr.io/krakjoe.
It also adds a new workflow called "docker" that builds such images.
Closes #297.