This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Fixed unsafe copying of exception handler #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is being dumb... a run for my fork on the same commit: https://travis-ci.org/pmmp/pthreads/jobs/414434233 |
|
A less invasive way to do this could be to assign it to a magic (or private) property in the thread's property store - one that isn't accessible by normal code. |
|
Thx @dktapps |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #753 .
See #861 (comment) for long explanation - the TL;DR is that serialization can cause objects to be modified on the child thread, which will cause problems.
The solution here is to serialize it in
pthreads_prepare_parent()and then unserialize during the thread's prepared startup. A similar solution will likely be needed for statics.