-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Extensions, Complete Headers and Multiple HDUs #2
Conversation
ignore python test files Got tests and HSL working
basic tests
WIP: heaer parsing correctly, moving on to data
all tests passing unit type explicit values
I'm the most unsure about the Data.Fits.Read module, which was a last minute addition. It makes it easy to parse the file and read specific headers in the The I think maybe the correct design won't emerge until we start writing real code against the library, which I will be doing in within the next month. |
@krakrjak Have you had a chance to look at this? |
Pushed a change of all Natural -> Int. Any thoughts on the larger refactors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a follow up PR where every top-level binding has a comment, but after reviewing this code and playing around a bit, I'm happy to accept it as is.
Thank you @seanhess for your contribution and may this just be the start of something great to allow this library to scratch more itches than when I started down the path many years ago.
Great work, let's do more to make this very useful for others down the road. I look forward to further collaboration.
As described in discussion in #1, adds more robust support for many things in order to parse FITS files from the NSO L1 Data Products.
Since we last spoke I added several things, including full support for BINTABLE, a method to read specific headers, and multiple refactors to better support extensions. Sorry for such a huge PR. Turns out our FITS files used just about every features in the spec!
There are still a few cleanup things to do, comments, formatting, etc, but I thought it would be good to get the PR in.