add a -w option to warn on reaping children #107
Conversation
|
Implements my suggestion in #106. Arguable this should be the default but it could introduce issues in tools that process the container outputs. |
src/tini.c
Outdated
| if (warn_on_reap > 0) { | ||
| PRINT_WARNING("Reaped child with pid: '%i'", current_pid); | ||
| } else { | ||
| PRINT_DEBUG("Reaped child with pid: '%i'", current_pid); |
There was a problem hiding this comment.
I'd rather keep the debug above so that it logs unconditionally (including for the "main child"), but have a PRINT_WARNING here dedicated to the case where the child is not the main child (i.e. this branch you're in).
We can also make the the warning more explicit. E.g. "Reaped orphaned process with pid: '%i'".
|
Thanks! Can we get an integration test for this in https://github.com/krallin/tini/blob/master/test/run_inner_tests.py to protect against regressions down the line? (I'm happy to help you with it / implement the test if you'd rather not do that yourself) |
|
Sounds good. I will resume this work next week, I wanted to have feedback before investing more into this. |
|
Thanks! |
zimbatm
force-pushed
the
warn-on-reap
branch
2 times, most recently
from
696ea61
to
acf4868
Compare
|
@krallin updated the tests but I think I've got the test matrix wrong and two axis are interfering with each-other. |
|
ping :) |
test/run_outer_tests.py
Outdated
| @@ -158,6 +158,7 @@ def main(): | |||
| Command(functional_base_cmd + ["-z"], fail_cmd).run(retcode=127 if args_disabled else 1) | |||
| Command(functional_base_cmd + ["-h"], fail_cmd).run(retcode=127 if args_disabled else 0) | |||
| Command(functional_base_cmd + ["zzzz"], fail_cmd).run(retcode=127) | |||
| Command(functional_base_cmd + ["-w"], fail_cmd).run(retcode=127) | |||
There was a problem hiding this comment.
This should be retcode=127 if args_disabled else 0: the MINIMAL=1 build does not accept arguments at all (it's the one Docker uses for their embedded version of Tini).
|
Hey @zimbatm — I'm sorry, I'm a little delayed on this since I'm at a work event off-site this week (and beginning of next). I added a few comments for now regarding the failure you experienced. |
|
no worries @krallin . Let me know what you think of the latest changes. |
Well designed software should not produce any zombie or re-parenting processes. This adds an option to warn in the logs when reaping of zombies is happening so that it can be monitored and fixed in subsequent releases of the software.
krallin
force-pushed
the
warn-on-reap
branch
from
76fb14d
to
8574e10
Compare
The common case for well designed software should be to not produce any
zombie processes.
This adds an option to warn in the logs when reaping of zombies is
happening so that it can be monitored as part of the software quality
lifecycle.