XDS Changes related to Connectathon. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 11, 2011 10:08
…lace around the stream. There could still be some improvement here some day in the future. The casting to a concrete class is problematic because wrapping InputStreams is a common thing to do.
… the correct "urn:uuid:" prefix.
…e ids were unique across all object types within the scope of a single request. This was overly strict because it is okay for the unique id of a submission set to be the same as the unique id of a document (The namespace for each is different). We found multiple cases of this at Connectathon. Rather than implement a more complex fix that separated the namespaces for the different object types it seemed most appropriate to just remove the uniqueness validation. Validating uniqueness within the scope of a single request really seems like a waste of time because it says nothing about the million other entries that might already be in the database. A true uniqueness check needs to be done by the database that holds all the other entries.
… needed for XDS update. Even though not implementing XDS update yet, some of the newer registry tests from IHE would fail without this information.
… needed for XDS update. Even though not implementing XDS update yet, some of the newer registry tests from IHE would fail without this information. (Missed this file in the previous commit).
…that is needed for XDS update. Even though not implementing XDS update yet, some of the newer registry tests from IHE would fail without this information. (Missed this file in the previous commit).
…ltiple valid ways to encode and this is not the only one
|
Hi David, |
|
Hi David, thanks a lot for your patches! |
|
Merged into IPF-2.2 branch |
|
Thanks! On Mon, Apr 18, 2011 at 7:52 AM, unixoid <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Martin,
Here are a collection of changes that I made as a result of this year's Connectathon.