Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized RetreiveImagingDocumentSet Classes #96

Closed
wants to merge 1 commit into from
Closed

Serialized RetreiveImagingDocumentSet Classes #96

wants to merge 1 commit into from

Conversation

clayseag
Copy link
Contributor

Hi Dmytro,

This change adds serialization to the RetrieveImagingDocumentSet classes:

  • RetrieveImagingDocumentSet
  • RetrieveStudy
  • RetrieveSeries

Thanks,

Clay

@unixoid
Copy link
Collaborator

unixoid commented Aug 13, 2012

Hi Clay,

your patches do not seem to base on the latest version of IPF sources. In particular, it does not seem appropriate to revert the changed serialVersionUID of RetrieveImagingDocumentSet and to make it again the same as in RetrieveDocumentSet, as well as to restore obsolere copyright notices. Cound you please actualize the patch?

Thanks and Best Regards
Dmytro

@clayseag
Copy link
Contributor Author

I’m sorry Dmytro. I thought my code was the latest and didn’t realize your pull may have updated it. I will make these changes ASAP.

From: Dmytro Rud [mailto:notifications@github.com]
Sent: Monday, August 13, 2012 1:47 PM
To: krasserm/ipf
Cc: Sebourn, Clay
Subject: Re: [ipf] Serialized RetreiveImagingDocumentSet Classes (#96)

Hi Clay,

you patches do not seem to base on the latest version of IPF sources. In particular, it does not seem appropriate to revert the changed serialVersionUID of RetrieveImagingDocumentSet and make it again the same as in RetrieveDocumentSet, as well as to restore obsolere copyright notices. Cound you please actualize the patch?

Thanks and Best Regards
Dmytro


Reply to this email directly or view it on GitHubhttps://github.com//pull/96#issuecomment-7707445.

@unixoid
Copy link
Collaborator

unixoid commented Aug 14, 2012

Deprecated by #97

@unixoid unixoid closed this Aug 14, 2012
@clayseag
Copy link
Contributor Author

Thanks…

From: Dmytro Rud [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 1:27 AM
To: krasserm/ipf
Cc: Sebourn, Clay
Subject: Re: [ipf] Serialized RetreiveImagingDocumentSet Classes (#96)

Deprecated by #97#97


Reply to this email directly or view it on GitHubhttps://github.com//pull/96#issuecomment-7719430.

alexandruti pushed a commit to alexandruti/ipf that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants