Replace ActorPublisher with GraphStage in streamz-camel-akka #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasserm
reviewed
Nov 7, 2017
|
|
||
| override def preStart(): Unit = { | ||
| consumerTemplate = streamContext.consumerTemplate | ||
| consumerTemplate.start() |
There was a problem hiding this comment.
Starting the template shouldn't be necessary.
There was a problem hiding this comment.
Okay. I removed the overridden preStart hook.
|
|
||
| private def consumeAsync()(implicit tag: ClassTag[A]): Unit = { | ||
| import streamContext.consumerTemplate |
There was a problem hiding this comment.
I reinstated the import, placing it in the createLogic method so that the consumerTemplate is accessible to the consumeAsync and consumed methods.
|
We will later have to unify your solution with |
|
Thanks, please squash your commits then I'll merge to master. |
…l-akka. Remove an unused import. Import streamContext.consumerTemplate and remove the preStart() hook.
chunjef
force-pushed
the
wip-replace-actorpublisher-with-graphstage
branch
from
f78eaa0
to
f411ed6
Compare
|
Thanks again, good work! |
|
My pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krasserm: This PR pertains to #32 and replaces the deprecated
ActorPublisherwithGraphStage. Note that I made this change only in the streamz-camel-akka subproject; I didn't replace the use ofActorPublisherin streamz-converter.