Add remote option #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-r` or `--remote` option which sends the video using a `data:video/mp4,base64` URL instead of a relative path.
Accidentally used `-r` when it was already being used for resolution, changed to just `--remote`
|
Thank you, this is a great idea! I'm just not sure about the reassignment of |
|
@krassowski Yeah I realized that after my first commit and changed it from |
krassowski
reviewed
Nov 23, 2019
| @@ -83,7 +85,6 @@ def manim(self, line, cell): | |||
| settings[arg] = False | |||
|
|
|||
| resolution_index = ( | |||
| user_args.index('-r') if '-r' in user_args else | |||
krassowski
reviewed
Nov 23, 2019
jupyter_manim/__init__.py
Outdated
|
|
||
|
|
||
| remote_index = ( | ||
| user_args.index('-r') if '-r' in user_args else |
|
How about now? If you have anything specific in mind I honestly don't care what the name is. |
|
Great! Thank you for you contribution. I will look into #5 and release a new version then. |
|
Oops, forgot to change the README. It still says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--remoteoption which sends the video with adata:video/mp4;base64,URL instead of a relative path. This is useful for when you are working on a remote machine like Google Colab and don't have access to the filesystem. Thedata:URL sends the entire base64 encoded file in thesrcof the video HTML if the--remoteoption is passed to the cell magic.I have tested this on Google Colab and it works like a charm. Would love to see this pushed so I can shorten by setup cell to just an import rather that all this code.
Appreciate this library!