This repository has been archived by the owner on May 22, 2024. It is now read-only.
Webhooks for Controller Manager API #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
force-pushed
the
kflansburg/webhooks
branch
from
f77a8bb
to
221ff4b
Compare
Signed-off-by: Kevin Flansburg <kevin.flansburg@gmail.com>
Signed-off-by: Kevin Flansburg <kevin.flansburg@gmail.com>
kflansburg
force-pushed
the
kflansburg/webhooks
branch
from
221ff4b
to
bb2564f
Compare
Signed-off-by: Kevin Flansburg <kevin.flansburg@gmail.com>
kflansburg
commented
Oct 12, 2021
| @@ -386,6 +386,26 @@ impl Operator for MooseTracker { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "admission-webhook")] | |||
There was a problem hiding this comment.
Figure out how to remove the original trait method, but still support the old API.
| #[cfg(feature = "admission-webhook")] | ||
| { | ||
| let task = warp::serve(self.filter) | ||
| // .tls() |
There was a problem hiding this comment.
Figure out where to load certs from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7