Feature/improved potential computation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MWFarField3D can be constructed from a MWSingleLayer3D. The waveimpedance is computed from alpha and beta. - MWDoubleLayerFarField3D added, which can be constructed from Maxwell double layer. This far-field operator is useful in the context of combined source problems, where the far-field must be computed from a single and a double layer far field operator. - For convenience for both farfield operators, an extra member waveimpedance was introduced which can serve as scaling factor. In case of the MWFarField3D type being constructed from a MWSingleLayer3D, the waveimpedance will be set accordingly. TO CONSIDER FOR FUTURE CHANGES: - In order to not break anything, MWFarField3D behaves as before. It should probably become a MWSingleLayerFarField3D, while MWFarField3D could replace the newly introduced abstract type MWFarField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWSingleLayerField3D and MWDoubleLayer3D can be constructed from MWSingleLayer3D and MWDoubleLayer3D
MWSingleLayerField3D uses now gamma, alpha, and beta just as the MWSingleLayer3D
MWFarField3D can be constructed from a MWSingleLayer3D. The waveimpedance is computed from alpha and beta.
MWDoubleLayerFarField3D added, which can be constructed from Maxwell double layer. This far-field operator is useful in the context of combined source problems, where the far-field must be computed from a single and a double layer far field operator.
For convenience for both farfield operators, an extra member waveimpedance was introduced which can serve as scaling factor. In case of the MWFarField3D type being constructed from a MWSingleLayer3D, the waveimpedance will be set accordingly.
TO CONSIDER FOR FUTURE CHANGES: