Make verifier cache configurable #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, yes I think it can do the job too. It's not pretty but I prefer your solution than mine 😅. I'm not really fan about non immutable object but you're right, for now I think this bundle need a big rewrite to allow more configuration customization. The best will be to do something like with doctrine cache with the ability to provide a service id or a class that will be instanciate only for this purpose. It's ok for me, you can close #18 and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #18
Makes the verifier cache (used to cache Google's Public Keys for ID token verification, see documentation)) configurable.
It's not pretty, but it's knowing that the bundle will be rewritten from scratch for a 2.0 release 🙈