Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default timeout for http client #146

Closed
wants to merge 1 commit into from
Closed

Set default timeout for http client #146

wants to merge 1 commit into from

Conversation

ankurk91
Copy link
Contributor

Hi,

It is recommended to have a sensible default HTTP timeout.

Laravel itself has set a default timeout to their HTTP client.

It should not be a breaking change for existing users.

@jeromegamez
Copy link
Member

Thanks for your contribution! This would be better suited to the SDK itself (https://github.com/kreait/firebase-php/blob/6.x/src/Firebase/Http/HttpClientOptions.php#L16), could you please create the PR there?

@ankurk91
Copy link
Contributor Author

@jeromegamez sure, i will

@ankurk91
Copy link
Contributor Author

@jeromegamez
When kreait/firebase-php#723 is merged , we still need to update the doc block in config file saying "indefinitely"

@jeromegamez
Copy link
Member

Yes, I'll do that once I released the SDK and have updated the Laravel Package with the bumped dependency, thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants