Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for include filters #15

Merged
merged 1 commit into from
Feb 18, 2020
Merged

support for include filters #15

merged 1 commit into from
Feb 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2020

  • Added a new option for file sources, which allows to specify a list
    of include and exclude filters
  • Added a new option for file sources, which allows to disable the
    --delete-excluded behaviour.

I am using this to solve the problem described in #14.
I kept the old exclude option to prevent breaking existing setups. It was not possible to just add an include option, because the order of the parameters is important.

- Added a new option for `file` sources, which allows to specify a list
  of `include` and `exclude` filters
- Added a new option for `file` sources, which allows to disable the
  `--delete-excluded` behaviour.
@ghost ghost requested a review from 4z3 February 3, 2020 15:43
@4z3 4z3 merged commit ed9fc66 into krebs:master Feb 18, 2020
@Mic92
Copy link
Contributor

Mic92 commented Feb 18, 2020

Maybe the old --exclude option could be deprecated using a warning message?

@4z3
Copy link
Contributor

4z3 commented Feb 18, 2020

Maybe the old --exclude option could be deprecated using a warning message?

Yes, we'll do that, but no hurry (from my side at least) as the old and new options don't really conflict each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants