-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix halo implementation and tiling artefact #220
Conversation
Old implementation prevents GUI to update the model list after addition
- Relocate all model record related utils to zoo.py - Replace constant dir/file/path names and relocate into __init__.py - Use pathlib for paths in related files who used such constants
Before it doesn't allow branch name to include `/` and `-` such as `qy/fix-github-actions`
I just fixed the problem in workflow: But it seems that I need to add and modify tests |
Hey @qin very nice, I like the pydantic validation a lot.. should we also add it to the plantseg configs? !!!wrong pr!!! This comment was for the ModelZoo PR |
It is problematic to have two prediction functions doing the same thing. Created an issue #222
Hey @lorenzocerrone, I
Please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good we can merge it :)
I improved the docstring based on Adrian's feedback: wolny/pytorch-3dunet#113 (comment) Since I'm already improving the docstrings, I also fixed the arg types and made some simple improvement of code. I'll merge this and work on the next. |
Removing the unused argument in |
Fix halo implementation and tiling artefact
Fix normalisation from patch-level intensity normalisation to image-levelSee my fix to
pytorch-3dunet
wolny/pytorch-3dunet#113 for more details.