Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ffmpeg.path if asar is enabled #10

Closed
espresso3389 opened this issue Jan 24, 2018 · 3 comments
Closed

Wrong ffmpeg.path if asar is enabled #10

espresso3389 opened this issue Jan 24, 2018 · 3 comments

Comments

@espresso3389
Copy link

ffmpeg.path returns path like ....\resources\app.asar\node_modules\@ffmpeg-installer\win32-x64\ffmpeg.exe regardless of asar state.
It should return ....\resources\app.asar.unpacked\node_modules\@ffmpeg-installer\win32-x64\ffmpeg.exe if asar is enabled.
@kribblo
Copy link
Owner

kribblo commented Jan 24, 2018

Looks like this known issue: electron/packager#740

It should be the responsibility of asar not to break paths, IMO.

@kribblo
Copy link
Owner

kribblo commented Jan 24, 2018

Added a note with workaround to the README: https://github.com/kribblo/node-ffmpeg-installer/blob/master/README.md#wrong-path-under-electron-with-asar-enabled

Handling special cases like that is outside the scope of ffmpeg-installer

@espresso3389
Copy link
Author

I see. Thanks so much for your information.

@kribblo kribblo mentioned this issue Dec 12, 2018
Closed
audionerd added a commit to wonderunit/storyboarder that referenced this issue Jan 11, 2022
@audionerd
find ffmpeg binary when Electron is running on Apple Silicon
c75d2bb 
related:
kribblo/node-ffmpeg-installer#10
kribblo/node-ffmpeg-installer#26
electron/electron#6262
kribblo/node-ffmpeg-installer#60
audionerd added a commit to wonderunit/storyboarder that referenced this issue Feb 25, 2022
@audionerd
find ffmpeg binary when Electron is running on Apple Silicon
492e689 
related:
kribblo/node-ffmpeg-installer#10
kribblo/node-ffmpeg-installer#26
electron/electron#6262
kribblo/node-ffmpeg-installer#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kribblo @espresso3389