Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bashisms in scripts #14

Open
dmuhamedagic opened this issue Sep 11, 2023 · 3 comments
Open

Bashisms in scripts #14

dmuhamedagic opened this issue Sep 11, 2023 · 3 comments

Comments

@dmuhamedagic
Copy link
Contributor

In the liveness script, which is quite properly a POSIX shell one, there are a number of bashisms. I'll see if I can make a PR.
@krig This is fantastic! Does it work? Do you have good logging? If so, I am going to use it for my new project. Thanks man!

@krig
Copy link
Owner

krig commented Sep 13, 2023

Hi! Oh, I haven't updated this project in ages so who knows if it is still viable :D But as far as I know it is still being used in production in at least one place.

I'm sure it's full of bashisms, any fixes you have are more than welcome!

@dmuhamedagic
Copy link
Contributor Author

dmuhamedagic commented Sep 13, 2023 via email

@krig
Copy link
Owner

krig commented Sep 15, 2023

Sounds good, no hurries or expectations from my side! Happy to take patches when or if they appear :)

P.S. How is life in general, let’s talk, I can contact you on WhatsApp if that’s OK with you!

Please do! Life is hectic, our baby just turned one, but it's great all the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants