Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add set_m_collisionFilterGroup() and set_m_collisionFilterMask() to ConcreteContactResultCallback #350

Closed
regnaio opened this issue Jan 25, 2021 · 1 comment

Comments

@regnaio
Copy link

regnaio commented Jan 25, 2021

In the file btCollisionWorld.h, ContactResultCallback has attributes m_collisionFilterGroup and m_collisionFilterMask. However, there is no way for us to set these values via ConcreteContactResultCallback, which is [JSImplementation="ContactResultCallback"] according to ammo.idl

We are able to set the group and mask values of ClosestRayResultCallback via set_m_collisionFilterGroup() and set_m_collisionFilterMask(). So, I'm unsure why we cannot do the same with ConcreteContactResultCallback.

Without this capability, we have little control over contactTest and when ConcreteContactResultCallback.addSingleResult is triggered.

Thank you for your time and help!

@regnaio regnaio changed the title Please add set_m_collisionFilterGroup(), set_m_collisionFilterMask() to ConcreteContactResultCallback Please add set_m_collisionFilterGroup(), set_m_collisionFilterMask() to ConcreteContactResultCallback Jan 25, 2021
@regnaio regnaio changed the title Please add set_m_collisionFilterGroup(), set_m_collisionFilterMask() to ConcreteContactResultCallback Please add set_m_collisionFilterGroup() and set_m_collisionFilterMask() to ConcreteContactResultCallback Jan 25, 2021
@regnaio
Copy link
Author

regnaio commented Jan 26, 2021

This can be resolved by adding

  attribute short m_collisionFilterGroup;
  attribute short m_collisionFilterMask;

under interface ContactResultCallback in ammo.idl

regnaio@d537f9b

For reference, a Dockerfile to easily build Ammo on any system is included: https://github.com/regnaio/ammo.js/blob/master/Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant