Add attributes m_collisionFilterGroup, m_collisionFilterMask to ContactResultCallback in ammo.idl #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #350
Please refer to the bullet source code for
ContactResultCallback
: https://github.com/kripken/ammo.js/blob/master/bullet/src/BulletCollision/CollisionDispatch/btCollisionWorld.h#L411Note how the
ContactResultCallback
constructor automatically setsm_collisionFilterGroup
tobtBroadphaseProxy::DefaultFilter
(value 1) andm_collisionFilterMask
tobtBroadphaseProxy::AllFilter
(value -1)ContactResultCallback
uses these 2 attributes inneedsCollision()
to determine whetheraddSingleResult(...)
should be triggeredThus, without the 2 added attributes in this PR, we cannot control when
addSingleResult
is triggered bycontactTest
, especially when using collision filter groups and masks on ourbtRigidBody
sCould we please add these 2 attributes to
ammo.idl
? Thank you for your time and help!(Note that the build files were generated using the command
cmake -B builds -DCLOSURE=1 -DTOTAL_MEMORY=268435456
with the environment based on the Dockerfile in #351 (comment). Please disregard these build files if another configuration is preferred)