Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceError: cannot find variable values #32

Closed
domenic opened this issue Dec 28, 2011 · 1 comment
Closed

ReferenceError: cannot find variable values #32

domenic opened this issue Dec 28, 2011 · 1 comment

Comments

@domenic
Copy link
Collaborator

domenic commented Dec 28, 2011

https://github.com/kriskowal/q/blob/master/q.js#L732 seems to reference a nonexistant values variable.
kriskowal added a commit that referenced this issue Jan 2, 2012
@kriskowal
Merge pull request #33 from DomenicDenicola/patch-1
f098c51 
Fix `Q.all` in the case of an empty array. #32
@kriskowal kriskowal mentioned this issue Jan 2, 2012
Closed
@kriskowal
Copy link
Owner

Fixed by #34

kriskowal added a commit that referenced this issue Jan 14, 2012
@kriskowal
Noted fix to #32 in change log.
f9a27bc
johnjbarton pushed a commit to johnjbarton/q that referenced this issue Feb 10, 2012
@domenic @johnjbarton
Fixing Q.all in the case of an empty array. kriskowalGH-32
782e1f9
johnjbarton pushed a commit to johnjbarton/q that referenced this issue Feb 10, 2012
@kriskowal @johnjbarton
Noted fix to kriskowal#32 in change log.
26dd64b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kriskowal @domenic